Conversation
rwb27
force-pushed
the
retire-file-manager
branch
from
a22beca to
ba398e9
Compare
`file_manager` was a previous attempt to handle actions that created files. It is retired in favour of the `Blob` class. I'm not aware of any examples of `file_manager` being used "in the wild" and it does not do anything that `Blob` can't do. We are therefore getting rid of it as vestigial code.
This is a bonus extra test, to stop the coverage diff being negative after deleting FileManager.
rwb27
force-pushed
the
retire-file-manager
branch
from
ba398e9 to
b21c7f1
Compare
Collaborator
Author
|
The coverage diff was negative, so I've made some testing improvements:
Neither is required to remove the file manager, but both are useful and I thought I'd be better off spending the time adding a test than justifying why I want to merge when the coverage diff is negative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_managerwas a previous attempt to handle actions that created files. It is retired in favour of theBlobclass. I'm not aware of any examples offile_managerbeing used "in the wild" and itdoes not do anything that
Blobcan't do.We are therefore getting rid of it as vestigial code.